Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Add an object model to clientIF ......................................................................
Patch Set 1: (1 inline comment) I think you have a valid point. .................................................... File vdsm/API.py Line 43: return self._cif.create(createParameters) This does create side effects because it modifies the original dict. By working on a shallow copy would ensure there are no side effects to this particular function, but if the called function doesn't respect that I don't have a particular strong opinion about this. It may be better to solve this properly (or not at all) than partially. -- To view, visit http://gerrit.ovirt.org/984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ee54277c87a02ac8dafe29a8761e2acf0f7397f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
