Dan Kenigsberg has submitted this change and it was merged. Change subject: Avoid to activate parent volume on cloning ......................................................................
Avoid to activate parent volume on cloning The benefit is that we can now create new snapshot volumes without looking at the parent. This is indispensable for live snapshots since the parent volume is in use by the VM. WARNING: if you run an SPM host with this change you need all the HSM hosts to have: I4b5cb55a868cb9bf5a720610273af139ee858a1a (Don't lock the image when preparing the VM path) and you won't be able use the domain from old SPMs/HSMs anymore. In this patch: * Do not activate the parent volume on cloning (it could be in use by the VM), the only information needed is the size and it can be provided as additional parameter in qemu-img * Do not change the volume permission to read-only when setting the parent to "internal" (it could be in use by the VM) Change-Id: I8a7d488da5ab0c27fc2e083976d4bc44e6f810e3 --- M vdsm/storage/volume.py 1 file changed, 15 insertions(+), 13 deletions(-) Approvals: Dan Kenigsberg: Verified Igor Lvovsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a7d488da5ab0c27fc2e083976d4bc44e6f810e3 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
