Igor Lvovsky has posted comments on this change. Change subject: Avoid to activate parent volume on cloning ......................................................................
Patch Set 6: Looks good to me, but someone else must approve (2 inline comments) Only minor things .................................................... File vdsm/storage/volume.py Line 870: # cwd = os.path.split(os.path.split(volume)[0])[0] Why this dead code? I know that it not your, but if you already touch this... Line 872: # Temprary fix for qemu-img creation problem Is comment still relevant? -- To view, visit http://gerrit.ovirt.org/570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a7d488da5ab0c27fc2e083976d4bc44e6f810e3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
