Dan Kenigsberg has posted comments on this change. Change subject: [WIP] Adding flowID ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/clientIF.py Line 648: try: I have imagined something more generic, embedded into wrapApiMethod and applying to all verbs. In any case, you cannot change self.log this way - it is raceful and would quickly explode in length (note that you add an Adapter on every api call, never removing). Instead, I think that you should copy the flowID to threadLocal, and have one constant LogAdapter that reads flowID from there when needed. -- To view, visit http://gerrit.ovirt.org/1221 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c818d7a90fea41663fd48620ac9718451a8662f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
