Saggi Mizrahi has posted comments on this change.
Change subject: Adding flowID
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
I would have put -2 if the patch wasn't so tiny.
Anyway, I still think flowID is useless but as long as it doesn't get in my way
and gets deprecated when we move to REST/QMF I don't care if there is another
stupid UUID in the logs.
....................................................
File vdsm/BindingXMLRPC.py
Line 139: threadLocal.flowID = self.headers.get('X-FlowID')
* Thread local storage is evil
* X- prefix is deprecated
(http://tools.ietf.org/html/draft-ietf-appsawg-xdash-02)
* Header name should be in a constant
--
To view, visit http://gerrit.ovirt.org/1221
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c818d7a90fea41663fd48620ac9718451a8662f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
