Dan Kenigsberg has posted comments on this change.
Change subject: Escape underscore as well
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/storageProviderConnectionMonitor.py
Line 171: return os.path.join(self.localPathBase,
self._remotePath.replace("/", "_").replace("_", "__"))
this change add a long line and does not fix the collision: both would end up
hello__world. you should probably use re for proper escaping.
--
To view, visit http://gerrit.ovirt.org/1245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
