Saggi Mizrahi has posted comments on this change.
Change subject: Escape underscore as well
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/storageProviderConnectionMonitor.py
Line 171: return os.path.join(self.localPathBase,
self._remotePath.replace("/", "_").replace("_", "__"))
OK you caught me, I noticed that my implementation varied from transformPath
and I just wanted to align the two. I hate transformPath and I don't think it
should be used at all as everyone who is using it at the moment is actually
doing stuff wrong.
When I get the opportunity to remove transformPath and not have all classes
depend on an arbitrary path transformation localPath will just be a random
folder name independent from the actual path as this is just stupid.
I just don't want to use transform path. I hate it.
--
To view, visit http://gerrit.ovirt.org/1245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
