Dan Kenigsberg has posted comments on this change. Change subject: Log exceptions when calling irs functions from XMLRPC ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/BindingXMLRPC.py Line 162: raise I understand the point of the patch, and support it. However, note that in case of an exception in the called function, wrapApiMethod returns an error code, instead of re-raising the exception. I am suggesting to do the same here. -- To view, visit http://gerrit.ovirt.org/1575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd560d3b110c91f5019c5a6af477926a1fbf1996 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
