Dan Kenigsberg has posted comments on this change. Change subject: Log exceptions when calling irs functions from XMLRPC (V2) ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .................................................... File vdsm/BindingXMLRPC.py Line 161: f.im_self.log.error(traceback.format_exc()) Please consider avoiding 'traceback' with exc_info, as requested earlier by Federico. -- To view, visit http://gerrit.ovirt.org/1575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd560d3b110c91f5019c5a6af477926a1fbf1996 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
