Dan Kenigsberg has posted comments on this change. Change subject: Support the quiesce flag during a live snapshot ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) -1 for visibility .................................................... File vdsm/libvirtvm.py Line 1699: if hasattr(libvirt, "VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE"): do we REALLY want to get into these checks? I prefer requiring a newer version of libvirt. Unlike libvirt, we cannot afford trying to support every version of every tool. Thought? -- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
