Federico Simoncelli has posted comments on this change. Change subject: Support the quiesce flag during a live snapshot ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/libvirtvm.py Line 1699: if hasattr(libvirt, "VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE"): I require a new version of libvirt (check vdsm.spec.in), but the problem is syncing with Fedora, the options are: 1) We wait for the support of quiesce in Fedora 2) We always fail on Fedora 3) We patch the Fedora RPM 4) We require a version that is not in Fedora yet (only rawhide probably) What is wrong with checking capabilities, I don't see how this is going to make it more complex. Between "trying to support every version of every tool" (which is not what I am doing) and "using only the rpm requirements to get new capabilities" there's a sweet spot. -- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
