Adam Litke has posted comments on this change. Change subject: Replace most traceback.format_exc() calls by exc_info ......................................................................
Patch Set 1: (1 inline comment) Please address my comment but other than that it looks good to me. .................................................... File vdsm/utils.py Line 134: (f, s), exc_info=True) Don't use the '%' operator in log messages because it incurs the formatting overhead whether or not the code path is even executed. You should just be able to pass f and s as parameters and the logger will format the message on-demand. -- To view, visit http://gerrit.ovirt.org/2259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
