Dan Kenigsberg has posted comments on this change.
Change subject: Replace most traceback.format_exc() calls by exc_info
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File vdsm/storage/misc.py
Line 150: log.error("Panic: %s", msg, exc_info=True)
thanks for cleaning this up.
....................................................
File vdsm/storage/storage_mailbox.py
Line 443: "monitoring thread caught exception; " \
trailing backslashes are redundant in parenthesis
--
To view, visit http://gerrit.ovirt.org/2259
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
