Dan Kenigsberg has posted comments on this change. Change subject: added support for mirror promisc mode ......................................................................
Patch Set 16: (2 inline comments) minor comment-related comments. .................................................... File vdsm/supervdsmServer.py Line 188: :param networkName: networkName bridge name to capture the traffic from bridge != network. I suggest this is the network name. .................................................... File vdsm/tc.py Line 2: # Copyright 2009-2011 Red Hat, Inc. 2012! -- To view, visit http://gerrit.ovirt.org/956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
