Peter V. Saveliev has posted comments on this change.
Change subject: added support for mirror promisc mode
......................................................................
Patch Set 8: Verified; I would prefer that you didn't submit this
(2 inline comments)
not breaks the vdsm but I'm not sure I'd like to see it this way
....................................................
File vdsm/supervdsmServer.py
Line 255: devId = out[11:16]
are you sure it is the safe way to extract the device id?
....................................................
File vdsm/tc.py
Line 38: '''
with «red,blue:miror» we'll get here ("red", "blue:mirror"), is it ok?
what exactly we expect here, just interface names separated with commas? what
the «:mirror» stands for?
--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
