Bala.FA has posted comments on this change. Change subject: DO NOT SUBMIT - wip - vds_bootstrap: add flags for installVirtualizationService and installGlusterService ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vds_bootstrap/vds_bootstrap.py Line 910: installGlusterService = False I see, default values are false for options installVirtualizationService and installGlusterService. The behaviour is either one should be passed. Suggestion: Report if both are false or have a default value 'true' for installVirtualizationService. -- To view, visit http://gerrit.ovirt.org/2504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I883a5c36ff72a7c59b3e6a8b33d06924a5781d20 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
