Why isn't this up on gerrit? Also, the new code supports iser. Just pass 'iser' as the initiator name. I know it's confusing but this is how the old interface was implemented. The new interface calls it interfaceName which is what it should have been called in the old API.
As I said, I don't like VDSM doing transport fallback, you should manually select the interface you want to use. Every host has two default interfaces 'default' which will use tcp and a default nic and 'iser' which will use iser. Currently you have no way of adding new iser interface 'I locked new interfaces to only be TCP' but I can easily change that. There is no external API for setting new iser interfaces but the new API for creating interfaces will have discussed on the list with other ovirt projects. ----- Original Message ----- > From: "Roi Dayan" <[email protected]> > To: [email protected] > Cc: "Roi Dayan" <[email protected]>, "Itzik Brown" <[email protected]> > Sent: Monday, March 5, 2012 2:36:12 AM > Subject: Re: iSER patch for VDSM > > > > Hi, > > Attached the patch for the latest update. > Added fixme line for the transport check. > Attached for review. > It's not tested yet. We are installing fedora 17 for it. > > > Thanks, > Roi > > > > On Thu, Mar 1, 2012 at 6:29 PM, Roi Dayan < [email protected] > > wrote: > > > > Hi, > > > The patch attached created on top of change I3cedeb6c: Implement > storage server connection aliasing > > > The patch adds a new config option "iscsi_transports" in section > "irs" that can accept transport list. > E.g. "iser,tcp" > When adding a new iscsi node first vdsm will try iser and then tcp. > > > The patch was not tested since the build of change I3cedeb6c fails. > > > > /usr/bin/pyflakes vdsm vdsm_cli vds_bootstrap vdsm_reg vdsm_hooks > vdsm/storage/storageServer.py:25: 'Thread' imported but unused > vdsm/storage/storageServer.py:25: 'RLock' imported but unused > vdsm/storage/storageServer.py:25: 'Event' imported but unused > vdsm/storage/storageServer.py:34: 'asyncmethod' imported but unused > vdsm/storage/storageServer.py:34: 'AsyncCallStub' imported but unused > make[2]: *** [check-local] Error 1 > make[2]: Leaving directory `/tmp/vdsm' > make[1]: *** [check-am] Error 2 > make[1]: Leaving directory `/tmp/vdsm' > make: *** [check-recursive] Error 1 > > > Thanks, > Roi > > > -- > > > > > Roi > > > > > -- > > > > > Roi > > _______________________________________________ > vdsm-patches mailing list > [email protected] > https://fedorahosted.org/mailman/listinfo/vdsm-patches > _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
