Hi, I changed the patch. I'll send it later today after I'll test it. In the new patch I'm not doing changes to header digest and I'm using the iface option.
I add another binding with: iscsiadm -m node -p portal -T target -I iser -o new in a normal case I usually del the default binding with: iscsiadm -m node -p portal -T target -I default -o delete but for some reason I don’t see it after adding the target with iser interface. Maybe the reason is VDSM doesn't specify target portal group (tpgt) when adding also the default binding. e.g. Without tpgt: iscsiadm -m node -p ip:port -T target -I default -o new with tpgt: iscsiadm -m node -p ip:port,1 -T target -I iser -o new When falling back to tcp I delete the iser binding. Thanks, Roi -----Original Message----- From: Dan Kenigsberg [mailto:[email protected]] Sent: Tuesday, March 06, 2012 8:58 AM To: VDSM Project Patches; Roi Dayan Cc: Saggi Mizrahi; Itzik Brown Subject: Re: iSER patch for VDSM On Mon, Mar 05, 2012 at 04:30:26PM +0000, Roi Dayan wrote: > Hi, > > With "the new code supports iser" do you mean the iface iser in iscsiadm? > I want to use, I don’t want to create a new one. > I did a fallback since I don’t have in the gui anywhere to choose between > iser and iscsi. > Now I see it doesn't help me anyway since if I want to use the iser > iface in iscsiadm, I need to set this iface when doing discovery since it > can't be changed later with op update. > > With a talk with Ayal Baron I was told I can currently submit the > patch to vdsm-patches without gerrit And to have a fixme comment about the > fallback (which doesn't really help right now since I need discovery anyway). > > From you're answer I understand it is possible to choose iser iface from the > gui? > How I do that? > I only have fields for ip,port,chap. I'm afraid you cannot. I'll try to explain Saggi's text, hopefully without introducing mistakes of my own: Vdsm's connectStorageServer accpets a parameter named initiatorName, which is abused and passed as-is to iscsiadm's -I argument. This can be abused in order to pass the special "iser" interface to iscsiadm. HOWEVER, I don't think that initiatorName has ever been used by ovirt Engine. Since I have very little knowledge of iscsiadm (and when it comes to iser even less), maybe you would agree to give me a more detailed explanation of your patch. A casual read of the man page makes we wonder: could a simple iscsiadm -m discoverydb -t st -p ip:port -I iser --discover do the trick for discovery? Could HeaderDigest mangling be avoided? BTW, Saggi, does it make sense to have our API accomodate discovery/login over multiple interfaces? Regards, Dan. _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
