Dan Kenigsberg has posted comments on this change.
Change subject: Adding the qemuImg command line
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File vdsm/qemuImg.py
Line 24: _qemuimg = CommandPath("qemu-img",
I hope Saggi is now happy
....................................................
File vdsm/utils.py
Line 819: else:
you start to like this awkward syntax too much! ;-)
(I personally do not know what people have against "return" within a loop...)
--
To view, visit http://gerrit.ovirt.org/2611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64310c719371a32b1527d9641077315811da9725
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
