Federico Simoncelli has posted comments on this change. Change subject: Adding the qemuImg command line ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/utils.py Line 819: else: The ideal flow for this method is: 1. if self._cmd is not set, then evaluate and set 2. return self._cmd Transforming 1 in a new exit point for the function (set and return) is not an improvement. The for-else construct is not awkward it's a great tool to avoid an additional flag variable. It can be used for both patterns "if all elements" and "if any of the elements". Amazing :-) -- To view, visit http://gerrit.ovirt.org/2611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64310c719371a32b1527d9641077315811da9725 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
