Saggi Mizrahi has posted comments on this change. Change subject: Fix the new lv_name field for the new lvm lib. ......................................................................
Patch Set 2: I would prefer that you didn't submit this My patch fixes that and doesn't assume stupid things about how things are formatted is uses the canonical way that VDSM uses to get device guids. I'm annoyed as it is with all the weird formatting assumptions that lvmcache uses. Stop reimplementing logic, devicemapper.py and multipath.py are balanced for speed and correctness, use their abilities. Don't optimize more when you don't have to. I don't want to start a stupid mine is bigger then yours war so I'd concede if I'm the only one that thinks that more shaky name mangling is NOT the solution. -- To view, visit http://gerrit.ovirt.org/2952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I988b72af48bc5024f410a0a4296d553d352c8440 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
