Dan Kenigsberg has posted comments on this change.

Change subject: Fix the new lv_name field for the new lvm lib.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

Saggi, this patch is plain and simple and I do not understand why you mock it 
so badly.

Your "competing" patch http://gerrit.ovirt.org/2940 introduces more complexity 
and stuff we know we would like to remove.

A proper solution would not expect lvm.py to provide the devicemapper GUID of 
the LV.

--
To view, visit http://gerrit.ovirt.org/2952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988b72af48bc5024f410a0a4296d553d352c8440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to