Igor Lvovsky has posted comments on this change. Change subject: BZ#773210 - Avoid infinite loop when delete volume failed during the merge ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/storage/image.py Line 969: time.sleep(10) The infinite loop will occur if we have problem with access storage (not like in original code). We spoke with Dan about it and we decided that preferable way is keep the task running (but not in tight loop). We can't raise exception here because it will fail the whole merge task that this function only last cleanup part of it -- To view, visit http://gerrit.ovirt.org/987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1368141fb240c9ca4e3fb3cfad04f88312cc46b5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
