Ayal Baron has posted comments on this change.
Change subject: BZ#773210 - Avoid infinite loop when delete volume failed
during the merge
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/storage/image.py
Line 969: time.sleep(10)
So instead of failing the merge you'd keep the VM locked forever because the
image is locked ?!?
Instead of raising you could log the problem and return without throwing an
exception.
If you want to try many times then use retry and put 60 as the number of
retries and 10s between each try:
try:
misc.retry(func, expectedException=Exception, tries=60,
timeout=None, sleep=10)
except Exception, e:
self.log.warning(...)
--
To view, visit http://gerrit.ovirt.org/987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1368141fb240c9ca4e3fb3cfad04f88312cc46b5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
