Dan Kenigsberg has posted comments on this change. Change subject: Fix pylint error in BindingXMLPRC ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) CRITICAL is not a good replacement for TRACE. On another matter: I love some patches, generally. But I prefer "topical" patches that may span across multiple files. I would prefer to see one patch eliminating logging.TRACE over several not-really-atomic ones. .................................................... File vdsm/BindingXMLRPC.py Line 848: logLevel = logging.CRITICAL actually, TRACE is supposed to be "even less important, and more verbose, than DEBUG". I suppose that I deserve spanking for this monkey-patching that I've done in my youth. If people here agree that logging.TRACE is too evil to stay, it has to be removed completely, not only here. -- To view, visit http://gerrit.ovirt.org/3437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I957bc2b6aff62ac0e450a8e712384acf0e7adbd8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
