Ryan Harper has posted comments on this change. Change subject: Fix pylint error in BindingXMLPRC ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/BindingXMLRPC.py Line 848: logLevel = logging.CRITICAL I now see that we defined a new level .TRACE as 5; I suppose that's what I get for trusting pylint. So in vdsm/vdsm we're defining a custom level, TRACE, at 5, so noisier than DEBUG at 10. I think we can retract the whole .TRACE patches as noise from pylint since doesn't seem to be able to extract these dynamic values even though their in the code. The alternative would be to use logging.NOTSET which is 0; but not clear that we want to do it. -- To view, visit http://gerrit.ovirt.org/3437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I957bc2b6aff62ac0e450a8e712384acf0e7adbd8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
