Ayal Baron has posted comments on this change. Change subject: Make ClusterLock stateless ......................................................................
Patch Set 2: (1 inline comment) I can't justify a -1 but I really don't like this way of verifying that it's locked. .................................................... File vdsm/storage/safelease.py Line 148: return False I wonder if it wouldn't be safer, faster and less error prone just to read the lease and compare host id and timestamp... I can't say I like the above. -- To view, visit http://gerrit.ovirt.org/3497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie50f5fa79220bc9c0c5e35187415c7ff26c6dd28 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
