Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Make ClusterLock stateless ......................................................................
Patch Set 7: (1 inline comment) I'm not sure I like the pep8 fixes in the same patch. I think it distracts from the real fix and would prefer it in a separate patch. .................................................... File vdsm/storage/misc.py Line 1160: continue iteratePids already guarantees ints, so this try block is no longer needed. -- To view, visit http://gerrit.ovirt.org/3497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie50f5fa79220bc9c0c5e35187415c7ff26c6dd28 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
