Dan Kenigsberg has posted comments on this change.
Change subject: vm payload: add file injection to vm
......................................................................
Patch Set 23: Looks good to me, but someone else must approve
(2 inline comments)
if this patch is verified, we can take it, and worry about cleanup in a
following patch - I know that you are tired of all these resends.
....................................................
File vdsm/mkimage.py
Line 29: from vdsm.constants import P_PAYLOAD_IMAGES
I'd prefer that P_PAYLOAD_IMAGES is defined here, in this module, and is kept
local.
there is no point exposing this location in constants
_P_PAYLOAD_IMAGES = constants.P_VDSM_RUN + 'payload'
Line 107: raise Exception('Cannot remove Fs that is not exists in: ' +
P_PAYLOAD_IMAGES)
s/is not/does not/
--
To view, visit http://gerrit.ovirt.org/2321
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
