Dan Kenigsberg has posted comments on this change. Change subject: vm payload: add file injection to vm ......................................................................
Patch Set 19: (2 inline comments) .................................................... File vdsm/mkimage.py Line 32: PAYLOAD_IMAGES_P = '/tmp' I personally did not understand the usefulness of the /var/run->/run change, but that is besides the point for this patch. Here, we should put everything under P_VDSM_RUN, and discuss in a different patch if we should change our default value for that constant. Line 106: if not path.startswith(PAYLOAD_IMAGES_P): yep, we should use os.path.abspath() to avoid this problem. -- To view, visit http://gerrit.ovirt.org/2321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
