Wenchao Xia has posted comments on this change. Change subject: Tunnel errors from child to parent in betterPopen ......................................................................
Patch Set 1: (1 inline comment) reviewed, and have some technic questions that I did not catch up with the code. By the way, the codes needs lot knowledge to understand, maybe add a few more info in the commit messages such as "parent could get error info of child by calling betterOpen.stderr.read()", would make people knows how it works faster. .................................................... File vdsm/betterPopen/createprocess.c Line 168: why errnofd[2] must be an array with size [2]? What different purpose are errnofd[0] and errnofd[1] used for? -- To view, visit http://gerrit.ovirt.org/4413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d4a132317e9cf0843671460a0876f615760731d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Wenchao Xia <xiaw...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
