Dan Kenigsberg has posted comments on this change. Change subject: Change to use WatchedFileHandler instead of FileHandler ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) shouldn't this be accompanied with dropping `copytruncate` from vdsm-logrotate.conf? .................................................... Commit Message Line 7: Change to use WatchedFileHandler instead of FileHandler I'd mention logger.conf in the subject. Line 13: associated with a new inode after the manual change. To make logging survie survive? -- To view, visit http://gerrit.ovirt.org/4463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf1cd7f3c7d568b8351eaa3ce262532caec94c7e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
