Mark Wu has posted comments on this change. Change subject: Change to use WatchedFileHandler instead of FileHandler in logger.conf ......................................................................
Patch Set 2: Dan, Let me clarify it. Changming means that the new log file is not created immediately on logrotate. But it will be created automatically if new log message generated by vdsm and logging works fine with the new created file. In my test, I find if we add the option 'create' in vdsm's logrotate configuration, the new log file can be created immediately by logrotate. Actually, I considered it when I submit the patch. But I found the 'create' option is already in logrotate's global configuration and thought the vdsm configuration could inherit the global option 'create'. I am not sure why logrotate doesn't create new log file on rotate. If we hope it's created on rotate, we can just add the option 'create' in vdsm's logrotate conf. -- To view, visit http://gerrit.ovirt.org/4463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf1cd7f3c7d568b8351eaa3ce262532caec94c7e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Changming Bai <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
