Dan Kenigsberg has posted comments on this change. Change subject: promisc: bug fixes, change name to port-mirroring ......................................................................
Patch Set 5: I would prefer that you didn't submit this (3 inline comments) .................................................... File vdsm/libvirtvm.py Line 2069: supervdsm.getProxy().unsetPortMirroring(nic.network) have we not agreed that this should not move out of releaseVm() ? .................................................... File vdsm/tc.py Line 47: def _process_request(command, raiseErr = True): this would fail pep8. avoid spaces in default ag value raiseErr=True but more importantly, it is not very pretty to return the retcode - raising the exception (and catching it outside) is much more pythonic. Line 75: if dev_in_qdisc(dev): this is raceful, since the device may disappear after the "if" and before the "del". I think you should catch the "del" exception, and swallow it if it is about a missing tun device. -- To view, visit http://gerrit.ovirt.org/4359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6848b39e01997ff1c6769e3de9f60ba083647d3b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
