Dan Kenigsberg has posted comments on this change. Change subject: promisc: bug fixes, change name to port-mirroring ......................................................................
Patch Set 6: I would prefer that you didn't submit this (2 inline comments) minor issues left. .................................................... File vdsm/tc.py Line 52: return out, retcode I see no reason to return retcode. Line 79: if e.errCode != 2: this requires a comment, or better, defining ERR_DEV_NOEXIST = 2 somewhere up. -- To view, visit http://gerrit.ovirt.org/4359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6848b39e01997ff1c6769e3de9f60ba083647d3b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
