Adam Litke has posted comments on this change.

Change subject: tests: Package up tests
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File tests/run_tests.sh.in
Line 3: LC_ALL=C PYTHONPATH="@pythondir@/vdsm:@datarootdir@/vdsm" @PYTHON@ 
@top_srcdir@/tests/testrunner.py $@
I can drop a README file there.

....................................................
File vdsm.spec.in
Line 652: %{_datadir}/%{vdsm_name}/tests/*.py*
I think we should install all tests.  There is no harm in deploying all of 
them.  In fact, it is better to test the widest possible set of scenarios.

--
To view, visit http://gerrit.ovirt.org/4451
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40a5d97b8cffcbaa465cab61aa890ff2520a4179
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Wenchao Xia <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to