Dan Kenigsberg has posted comments on this change. Change subject: tests: Package up tests ......................................................................
Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) That's somewhat different from Wenchao's take on list, so I'd like to see that he's on board. I'm happy with this and the following patch. .................................................... File tests/run_tests.sh.in Line 2: prefix="@prefix@" that's confusing, since no $prefix is explicitly used here. (but I have no idea for improvement atm) -- To view, visit http://gerrit.ovirt.org/4451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40a5d97b8cffcbaa465cab61aa890ff2520a4179 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Wenchao Xia <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
