Zhou Zheng Sheng has posted comments on this change.
Change subject: Fixing pep8 in vdsm/define.py
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Nice
....................................................
File vdsm/define.py
Line 73: 'message': 'Guest agent
non-responsive'}},
How about:
errCode = {
'noVM':
{'status':
{'code': 1, 'message': 'Virtual machine does not exist'}},
'nfsErr':
{'status':
{'code': 3, 'message': 'Image repository access timeout'}},
'exist':
{'status':
{'code': 4, 'message': 'Virtual machine already exists'}},
'noVmType':
{'status':
{'code': 5, 'message': 'Unsupported VM type'}},
'down':
{'status':
{'code': 6, 'message': 'Virtual machine is down'}},
'copyerr':
{'status':
{'code': 7, 'message': 'Copy failed'}},
'sparse':
{'status':
{'code': 8, 'message': 'sparse creation faild'}},
'createErr':
{'status':
{'code': 9, 'message':
'Error creating the requested virtual machine'}},
'noConPeer':
{'status':
{'code': 10, 'message': 'Could not connect to peer VDS'}},
'MissParam':
{'status':
{'code': 11, 'message': 'Missing required parameter'}},
'migrateErr':
{'status':
{'code': 12, 'message': 'Fatal error during migration'}},
'imageErr':
{'status':
{'code': 13, 'message': 'Drive image file %s could not be found'}},
'outOfMem':
{'status':
{'code': 14, 'message': 'Not enough free memory to create '
'virtual machine'}},
'unexpected':
{'status':
{'code': 16, 'message': 'Unexpected exception'}},
'unsupFormat':
{'status':
{'code': 17, 'message': 'Unsupported image format'}},
'ticketErr':
{'status':
{'code': 18, 'message': 'Error while setting spice ticket'}},
'nonresp':
{'status':
{'code': 19, 'message': 'Guest agent non-responsive'}}, }
--
To view, visit http://gerrit.ovirt.org/4536
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
