Zhou Zheng Sheng has posted comments on this change.

Change subject: Fixing pep8 in vdsm/define.py
......................................................................


Patch Set 2: Verified

The changes pass vdsm test.

pydiff report:

$ pydiff define*.py
2 difference(s)
first file: defineo.py
second file: define.py

((28, 'Error creating the requested virtual machine'),
 (44, 'Error creating the requested VM'))

((33, 'Not enough free memory to create virtual machine'),
 (61, 'Not enough free memory to create VM'))


This means the only change in syntax logic is changing the string. If this 
change is acceptable, then the patch does not break anything.

--
To view, visit http://gerrit.ovirt.org/4536
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <[email protected]>
Gerrit-Reviewer: Bing Bu Cao <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to