Federico Simoncelli has posted comments on this change. Change subject: Fix attachSD and masterMigrate for domain version 3 ......................................................................
Patch Set 5: (1 inline comment) .................................................... File vdsm/storage/sp.py Line 859: if not newmsd.hasVolumeLeases(): Not necessarily, it was a trick used (VERSION < 3) to speed up the acquirement process (in case in the past the SPM wasn't cleanly released on the destination domain). With VERSION == 3 it's completely wrong and it shouldn't be executed. -- To view, visit http://gerrit.ovirt.org/4037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
