Eduardo has posted comments on this change. Change subject: Fix attachSD and masterMigrate for domain version 3 ......................................................................
Patch Set 9: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/storage/sp.py Line 859: if not newmsd.hasVolumeLeases(): Since mixed pools are forbidden we can assume that the newmsd is using the same safelease as curmsd. Line 949: dom.releaseHostId(self.id) Why are you releasing your Host ID? -- To view, visit http://gerrit.ovirt.org/4037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
