Bing Bu Cao has posted comments on this change.
Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 2004: def _qemugaShutdown(self):
Actually,before this patch set,the shutdown() in vm.py will call it.
But as Gal said the shutdown logic in vm.py is not clear so I removed that.
Maybe you can review the previous patch sets and reviews from Gal Hammer and
Barak.
I do hope somebody can call my function. ;)
....................................................
File vdsm/vm.py
Line 863: elif utils.tobool(self.conf.get('acpiEnable','true')):
No,you are right.I but I send one patch about this before,approved,but not
merged.
But I think it is better not making the maintainer you to rebase this file
twice.
;p
--
To view, visit http://gerrit.ovirt.org/5640
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If934c68552888c69c5a971c6f6140f59a9c6acc7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Bing Bu Cao <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
