Dan Kenigsberg has posted comments on this change.
Change subject: Add a channel in vdsm for introducing qemu-ga
......................................................................
Patch Set 10: I would prefer that you didn't submit this
(2 inline comments)
I'm afraid I have to repeat what I've written on Patch Set 3.
....................................................
File vdsm/vm.py
Line 859: elif utils.tobool(self.conf.get('acpiEnable', 'true')):
why are is this (and other) cleanup in this commit? they serve only as a
confusion to me.
Please put them in a separate patch.
Hey, I see that I've already said that in patchset 3. I believe that your
former cleanup patch was waiting for someone to verify it. *You* should find
this someone, I cannot do this on my own.
Please stack this patch on top of the cleanup patch(es), rebase, and resubmit.
Line 877: if self.conf.get('acpiEnable', 'true').lower() != "true":
why you are not moving to tobool here?
--
To view, visit http://gerrit.ovirt.org/5640
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If934c68552888c69c5a971c6f6140f59a9c6acc7
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <m...@linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Bing Bu Cao <m...@linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Gal Hammer <gham...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
