Igor Lvovsky has posted comments on this change.

Change subject: configNet: atomicBackup: it's fine if a new file disappears
......................................................................


Patch Set 1: I would prefer that you didn't submit this

ACK, but
Please, split out the test (for downstream sake)

Dan, I think the split these patches to 3 is too artificial.
I would prefer, two patches, one with test (squash both tests fixes together) 
and second with code fix (again squash all 3  fixes together)

--
To view, visit http://gerrit.ovirt.org/5954
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2925bc9b4db86d9a38fad761e58d164b3ad7bfd4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to