Dan Kenigsberg has posted comments on this change.

Change subject: configNetTests: test atomicBackup
......................................................................


Patch Set 2:

I actually prefer multiple, short, topical patches. I think it makes the life 
of the reviewer (and of the future git-blamer) much simpler.

I also prefer having a functional change and its test on the same commit.

However, to make my only reviewer happier, I've rehashed my patches, and 
splited code from test.

--
To view, visit http://gerrit.ovirt.org/5954
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2925bc9b4db86d9a38fad761e58d164b3ad7bfd4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to