Dan Kenigsberg has posted comments on this change.
Change subject: MOM Integration
......................................................................
Patch Set 11: I would prefer that you didn't submit this
(2 inline comments)
thanks, Mark, for the update. I have very few stylistic comments.
....................................................
File vdsm/ksm.py
Line 109: KSM_PARAMS = ('run', 'sleep_millisecs', 'pages_to_scan')
do you envisage someone outside this module using this tupple? if not, keep
_PRIVATE, or in-function.
....................................................
File vdsm/MOM.py
Line 30: class momThread(threading.Thread):
style: class names should begin with Upper case (yeah, we have ugly baggage not
conforming, but let's improve!)
the name of the module, though, would better be lower-case mom.py (I think).
--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
