Antoni Segura Puimedon has uploaded a new change for review. Change subject: Added unittests for _addNetworkValidation, vlanId, validateBondingName and validateBondingOptions. ......................................................................
Added unittests for _addNetworkValidation, vlanId, validateBondingName and validateBondingOptions. The test for validateBondingOptions monkey patches os.path.exists to allow to test just the logic of the method, which uses sysfs to determine if the option is valid. The test of _addNetworkValidation goes over all the logic branches to test that the proper exceptions are thrown. It monkey patches the network detection method of the netinfo module to avoid real network detection at test time. Change-Id: Ifd8bb649685fac00640e894a4484cdb0cc0b2f1c Signed-off-by: Antoni Segura Puimedon <[email protected]> --- M tests/configNetworkTests.py 1 file changed, 204 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/6198/1 -- To view, visit http://gerrit.ovirt.org/6198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd8bb649685fac00640e894a4484cdb0cc0b2f1c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
