Dan Kenigsberg has posted comments on this change.
Change subject: Added tests for _addNetworkValidation and helpers.
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
Thanks, two minor comments.
....................................................
File tests/configNetworkTests.py
Line 60: configNetwork.ne.ERR_BAD_VLAN)
it's better to align args according to the opening parenthesis (unless there is
a serious lack of space)
Line 122: return [re.findall(r'(\w+):', line)[1] for line in
out.split('\n') \
we do not care about the order of options, we do not expect anyone to change to
output, but we do care about quick testing of "in" - we'd better return a
frozenset().
--
To view, visit http://gerrit.ovirt.org/6198
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd8bb649685fac00640e894a4484cdb0cc0b2f1c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
