Zhou Zheng Sheng has posted comments on this change. Change subject: make vdsm/storage/task.py PEP 8 clean ......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve (2 inline comments) Verify: Run through ./autobuild.sh . pydiff finds two changes in code logic. The changes are acceptable. Please see the inline comments. Review: Style looks OK. .................................................... File vdsm/storage/task.py Line 783: except se.TaskStateTransitionError: "e" is not used, so deleting it is OK. Line 1129: code = None In the old file, 'code' is assigned a value in the 'except' statement. If there is no exception, 'code' will be an undefined variable. Its value is used in the "if self.aborting()" statement and 'flake8' report a warning for this. Here giving 'code' an initial value is nice. -- To view, visit http://gerrit.ovirt.org/6355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35cbbdbc163bab237be9d824974fbd8435a63f06 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Bing Bu Cao <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
