Dan Kenigsberg has posted comments on this change. Change subject: make vdsm/storage/task.py PEP 8 clean ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) Thanks for this big change. I think that one choice there is non-perfect. .................................................... File vdsm/storage/task.py Line 1129: code = None code always holds a numerical code number. I know that this "None" is never going to be used, but for the same reason you assign it a value, I think this value should be 0 (meaning "no error" in this file). -- To view, visit http://gerrit.ovirt.org/6355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35cbbdbc163bab237be9d824974fbd8435a63f06 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Bing Bu Cao <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
